Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1171673002: Have LayoutObject::decoratedName() decorate for multicol spanners. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
Reviewers:
dsinclair
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Have LayoutObject::decoratedName() decorate for multicol spanners. R=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196763

Patch Set 1 #

Patch Set 2 : Verboten to access style() here, apparently. Call spannerPlaceholder() instead, then. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/layout/LayoutObject.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
No layout tests are affected by this change, but it's useful to see which objects ...
5 years, 6 months ago (2015-06-09 09:35:13 UTC) #1
dsinclair
lgtm
5 years, 6 months ago (2015-06-09 13:39:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171673002/20001
5 years, 6 months ago (2015-06-09 13:40:17 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 13:44:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196763

Powered by Google App Engine
This is Rietveld 408576698