Issue 1171673002: Have LayoutObject::decoratedName() decorate for multicol spanners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1171673002: Have LayoutObject::decoratedName() decorate for multicol spanners. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)

Modified:
5 years, 6 months ago

Reviewers:
dsinclair

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Have LayoutObject::decoratedName() decorate for multicol spanners. R=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196763

Patch Set 1 #

Patch Set 2 : Verboten to access style() here, apparently. Call spannerPlaceholder() instead, then. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	Source/core/layout/LayoutObject.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

mstensho (USE GERRIT)

No layout tests are affected by this change, but it's useful to see which objects ...

5 years, 6 months ago (2015-06-09 09:35:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171673002/20001

5 years, 6 months ago (2015-06-09 13:40:17 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-09 13:44:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196763

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages