sky/engine/core/painting/LayoutRoot.cpp - Issue 1171643002: Make SkyShell stop crashing on scroll in Stocks2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/painting/LayoutRoot.cpp

Issue 1171643002: Make SkyShell stop crashing on scroll in Stocks2. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/painting/LayoutRoot.cpp

diff --git a/sky/engine/core/painting/LayoutRoot.cpp b/sky/engine/core/painting/LayoutRoot.cpp

index a2eedc4ea9ab0e9d6fb8636a820f04182d01c14b..c3ab733308c9894a6717259b0c4ba7093562f1c2 100644

--- a/sky/engine/core/painting/LayoutRoot.cpp

+++ b/sky/engine/core/painting/LayoutRoot.cpp

@@ -37,6 +37,8 @@ LayoutRoot::LayoutRoot()

LayoutRoot::~LayoutRoot()

{

+ if (!m_document->needsAttach())

+ m_document->detach();

}

Element* LayoutRoot::rootElement() const

« no previous file with comments | « no previous file | no next file » | no next file with comments »