Issue 1171643002: Make SkyShell stop crashing on scroll in Stocks2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1171643002: Make SkyShell stop crashing on scroll in Stocks2. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make SkyShell stop crashing on scroll in Stocks2. This is just another hack on top of the hack that is LayoutRoot. We will want to untangle Document ownership further as we iterate on LayoutRoot. For now LayoutRoot is both very inefficient (allocates a new Frame for each one!) as well as crashy like this (by not actually owning the document but rather grabbing it off the "rootElement" assigned to it). This at least fixes this common crasher for now. https://github.com/domokit/mojo/issues/206 R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/278f37a8fd5e3a58a220620f339722806a50871f

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	sky/engine/core/painting/LayoutRoot.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

5 years, 6 months ago (2015-06-08 19:41:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
278f37a8fd5e3a58a220620f339722806a50871f (presubmit successful).

Expand Messages | Collapse Messages