Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 1171583003: Rework BoxBorderPainter's mitre clipping logic (Closed)

Created:
4 years, 11 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, fs
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, reed1, robertphillips, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rework BoxBorderPainter's mitre clipping logic Change the border clip mitre logic to operate with tri-states (no mitre, anti-aliased mitre, non-antialiased mitre). Consolidate the mitre and clip computation logic. Functional side effect: mitre anti-aliasing is now handled similarly for opaque and non-opaque edges (AA when drawing AA edges, non-AA when drawing non-AA edges, in order to minimize the use of clipping). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196698

Patch Set 1 #

Patch Set 2 : use mitres compatible with aa #

Patch Set 3 : minor cleanup #

Patch Set 4 : keep overdraw disabled when using aa for now #

Patch Set 5 : expectations #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -71 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/paint/BoxBorderPainter.h View 1 2 2 chunks +9 lines, -2 lines 1 comment Download
M Source/core/paint/BoxBorderPainter.cpp View 1 2 3 8 chunks +79 lines, -69 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
f(malita)
Layout test diffs: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/65420/layout-test-results/results.html A couple of them are seam bleed progressions: css2.1/t0805-c5517-brdr-s-00-c.html css3/blending/background-blend-mode-data-uri-svg-image.html The ...
4 years, 10 months ago (2015-06-08 19:25:42 UTC) #2
fs
lgtm https://codereview.chromium.org/1171583003/diff/80001/Source/core/paint/BoxBorderPainter.h File Source/core/paint/BoxBorderPainter.h (right): https://codereview.chromium.org/1171583003/diff/80001/Source/core/paint/BoxBorderPainter.h#newcode31 Source/core/paint/BoxBorderPainter.h:31: enum MitreType { Maybe MiterType (etc.) so them ...
4 years, 10 months ago (2015-06-08 21:06:31 UTC) #3
chrishtr
lgtm
4 years, 10 months ago (2015-06-08 21:40:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171583003/80001
4 years, 10 months ago (2015-06-08 21:41:06 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-08 21:44:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196698

Powered by Google App Engine
This is Rietveld 408576698