Basic Sky shell for iOS targets

Basic Sky shell for iOS targets

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/1cbfd820a0e532a1be6124b59d23e87c33471f96

[abarth-chromium, 2015-06-05 22:56:07]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-06-05 22:56:09]

LGTM

Is this missing BUILD.gn changes?

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/Entitlements....
File sky/shell/ios/Entitlements.xcent (right):

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/Entitlements....
sky/shell/ios/Entitlements.xcent:6: <string>F5T262WGN6.com.google.sky</string>
We shouldn't be using the com.google namespace.  Can we use org.domokit.sky
instead?

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/Info.plist
File sky/shell/ios/Info.plist (right):

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/Info.plist#ne...
sky/shell/ios/Info.plist:16: <string>com.google.sky</string>
Same here.  We use org.domokit.sky in Java too.

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/Info.plist#ne...
sky/shell/ios/Info.plist:44: <string>com.google.mojo</string>
org.domokit.mojo

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/Info.plist#ne...
sky/shell/ios/Info.plist:55: <key>com.google.sky.load_url</key>
org.domokit.sky.load_url

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/Info.plist#ne...
sky/shell/ios/Info.plist:65: <string>iphonesimulator</string>
Do these cause trouble when running on a real device?

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/main_ios.mm
File sky/shell/ios/main_ios.mm (right):

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/main_ios.mm#n...
sky/shell/ios/main_ios.mm:43: int main(int argc, char* argv[]) {
We'll refactor this later, but this is fine for now.

In the long term, we'll want to move |main| into a SkyDemo project that uses
SkyShell as a library.  For example, on Android, we have both SkyDemo and
Stocks, which both depend on SkyShell but have two different mains.

Anyway, it's not something to worry about for this initial landing.

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/main_ios.mm#n...
sky/shell/ios/main_ios.mm:50: auto result = false;
bool result = false

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/platform_serv...
File sky/shell/ios/platform_service_provider_ios.cc (right):

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/platform_serv...
sky/shell/ios/platform_service_provider_ios.cc:6: #include
"sky/engine/wtf/Assertions.h"
You shouldn't need to include any of these headers from inside the engine in
this file.

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/platform_serv...
sky/shell/ios/platform_service_provider_ios.cc:35: mojo::MessagePipe pipe;
I suspect there's a fancier way do this without mentioning MessagePipe directly.

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/sky_app_deleg...
File sky/shell/ios/sky_app_delegate.mm (right):

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/sky_app_deleg...
sky/shell/ios/sky_app_delegate.mm:6: #import "sky_view_controller.h"
Please use paths relative to src.

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/sky_surface.mm
File sky/shell/ios/sky_surface.mm (right):

https://codereview.chromium.org/1171573002/diff/1/sky/shell/ios/sky_surface.m...
sky/shell/ios/sky_surface.mm:14: 
Plase combine and sort these two groups of includes includes.

[Chinmay, 2015-06-10 23:14:50]

Committed patchset #2 (id:20001) manually as
1cbfd820a0e532a1be6124b59d23e87c33471f96 (presubmit successful).