Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: src/IceTargetLoweringX8632.h

Issue 1171563002: Subzero: Emit ARM build-attributes in the file scope (as header). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: use class final, fix for mips32 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringX8632.h
diff --git a/src/IceTargetLoweringX8632.h b/src/IceTargetLoweringX8632.h
index def9dcd882ef471ed6e48b952d76380cc3f35878..ca26fe185e8bea53b4cbe5ea55ffe102eb810166 100644
--- a/src/IceTargetLoweringX8632.h
+++ b/src/IceTargetLoweringX8632.h
@@ -581,8 +581,8 @@ class TargetDataX8632 : public TargetDataLowering {
TargetDataX8632 &operator=(const TargetDataX8632 &) = delete;
public:
- static TargetDataLowering *create(GlobalContext *Ctx) {
- return new TargetDataX8632(Ctx);
+ static std::unique_ptr<TargetDataLowering> create(GlobalContext *Ctx) {
+ return std::unique_ptr<TargetDataLowering>(new TargetDataX8632(Ctx));
}
void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) const final;
@@ -597,6 +597,23 @@ private:
template <typename T> static void emitConstantPool(GlobalContext *Ctx);
};
+class TargetHeaderX8632 final : public TargetHeaderLowering {
+ TargetHeaderX8632() = delete;
+ TargetHeaderX8632(const TargetHeaderX8632 &) = delete;
+ TargetHeaderX8632 &operator=(const TargetHeaderX8632 &) = delete;
+
+public:
+ static std::unique_ptr<TargetHeaderLowering> create(GlobalContext *Ctx) {
+ return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderX8632(Ctx));
+ }
+
+protected:
+ explicit TargetHeaderX8632(GlobalContext *Ctx);
+
+private:
+ ~TargetHeaderX8632() = default;
+};
+
} // end of namespace Ice
#endif // SUBZERO_SRC_ICETARGETLOWERINGX8632_H

Powered by Google App Engine
This is Rietveld 408576698