Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: src/IceTargetLoweringMIPS32.h

Issue 1171563002: Subzero: Emit ARM build-attributes in the file scope (as header). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: use class final, fix for mips32 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | src/IceTargetLoweringMIPS32.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringMIPS32.h
diff --git a/src/IceTargetLoweringMIPS32.h b/src/IceTargetLoweringMIPS32.h
index cb583b553d9df1257be46f7e3f528dad3ca59d3f..b6c325a4540ab7109afafdbf996a9a603f1c754f 100644
--- a/src/IceTargetLoweringMIPS32.h
+++ b/src/IceTargetLoweringMIPS32.h
@@ -56,18 +56,23 @@ public:
const char *getConstantPrefix() const final { return ""; }
void emit(const ConstantUndef *C) const final {
+ (void)C;
llvm::report_fatal_error("Not yet implemented");
}
void emit(const ConstantInteger32 *C) const final {
+ (void)C;
llvm::report_fatal_error("Not yet implemented");
}
void emit(const ConstantInteger64 *C) const final {
+ (void)C;
llvm::report_fatal_error("Not yet implemented");
}
void emit(const ConstantFloat *C) const final {
+ (void)C;
llvm::report_fatal_error("Not yet implemented");
}
void emit(const ConstantDouble *C) const final {
+ (void)C;
llvm::report_fatal_error("Not yet implemented");
}
@@ -128,8 +133,8 @@ class TargetDataMIPS32 : public TargetDataLowering {
TargetDataMIPS32 &operator=(const TargetDataMIPS32 &) = delete;
public:
- static TargetDataLowering *create(GlobalContext *Ctx) {
- return new TargetDataMIPS32(Ctx);
+ static std::unique_ptr<TargetDataLowering> create(GlobalContext *Ctx) {
+ return std::unique_ptr<TargetDataLowering>(new TargetDataMIPS32(Ctx));
}
void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) const final;
@@ -144,6 +149,23 @@ private:
template <typename T> static void emitConstantPool(GlobalContext *Ctx);
};
+class TargetHeaderMIPS32 final : public TargetHeaderLowering {
jvoung (off chromium) 2015/06/11 22:12:32 added the mips variant without overrides to keep t
+ TargetHeaderMIPS32() = delete;
+ TargetHeaderMIPS32(const TargetHeaderMIPS32 &) = delete;
+ TargetHeaderMIPS32 &operator=(const TargetHeaderMIPS32 &) = delete;
+
+public:
+ static std::unique_ptr<TargetHeaderLowering> create(GlobalContext *Ctx) {
+ return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderMIPS32(Ctx));
+ }
+
+protected:
+ explicit TargetHeaderMIPS32(GlobalContext *Ctx);
+
+private:
+ ~TargetHeaderMIPS32() = default;
+};
+
} // end of namespace Ice
#endif // SUBZERO_SRC_ICETARGETLOWERINGMIPS32_H
« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | src/IceTargetLoweringMIPS32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698