Subzero: Emit ARM build-attributes in the file scope (as header).

src/IceTargetLowering.cpp

Index: src/IceTargetLowering.cpp
diff --git a/src/IceTargetLowering.cpp b/src/IceTargetLowering.cpp
index 49c370ab151feda68d8bdafeab3e9a3d1dd31edc..d1472fa626c8f6b16e15718b9c0017aff33cc6ae 100644
--- a/src/IceTargetLowering.cpp
+++ b/src/IceTargetLowering.cpp
@@ -438,10 +438,22 @@ TargetDataLowering::createLowering(GlobalContext *Ctx) {
     return std::unique_ptr<TargetDataLowering>(TargetData##X::create(Ctx));
 #include "llvm/Config/SZTargets.def"

[jvoung (off chromium), 2015/06/11 22:12:32]

Also updated the MIPS port to have create() return the unique_ptr.

 
-  llvm_unreachable("Unsupported target data lowering");
-  return nullptr;
+  llvm::report_fatal_error("Unsupported target data lowering");
 }
 
 TargetDataLowering::~TargetDataLowering() {}
 
+std::unique_ptr<TargetHeaderLowering>
+TargetHeaderLowering::createLowering(GlobalContext *Ctx) {
+  TargetArch Target = Ctx->getFlags().getTargetArch();
+#define SUBZERO_TARGET(X)                                                      \
+  if (Target == Target_##X)                                                    \
+    return std::unique_ptr<TargetHeaderLowering>(TargetHeader##X::create(Ctx));

[John, 2015/06/08 23:22:27]

you don't need

std::unique_ptr<>

here. Not that it causes any issues -- g++ should be able to effectively
inline-and-optimize-out the move ctors for you. Nonetheless,

return TargetHeader##X::create(Ctx);

should do the trick. Not sure, though...

[jvoung (off chromium), 2015/06/11 22:12:32]

Ah right -- Done.

+#include "llvm/Config/SZTargets.def"
+
+  llvm::report_fatal_error("Unsupported target header lowering");
+}
+
+TargetHeaderLowering::~TargetHeaderLowering() {}
+
 } // end of namespace Ice