Subzero: Emit ARM build-attributes in the file scope (as header).

src/IceTargetLowering.cpp

 //===- subzero/src/IceTargetLowering.cpp - Basic lowering implementation --===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the skeleton of the TargetLowering class,
@@ skipping 418 matching lines @@
   Str << getConstantPrefix();
   emitWithoutPrefix(C);
 }
 
 std::unique_ptr<TargetDataLowering>
 TargetDataLowering::createLowering(GlobalContext *Ctx) {
   TargetArch Target = Ctx->getFlags().getTargetArch();
 #define SUBZERO_TARGET(X)                                                      \
   if (Target == Target_##X)                                                    \
     return std::unique_ptr<TargetDataLowering>(TargetData##X::create(Ctx));
 #include "llvm/Config/SZTargets.def"

[jvoung (off chromium), 2015/06/11 22:12:32]

Also updated the MIPS port to have create() return the unique_ptr.

 
-  llvm_unreachable("Unsupported target data lowering");
-  return nullptr;
+  llvm::report_fatal_error("Unsupported target data lowering");
 }
 
 TargetDataLowering::~TargetDataLowering() {}
 
+std::unique_ptr<TargetHeaderLowering>
+TargetHeaderLowering::createLowering(GlobalContext *Ctx) {
+  TargetArch Target = Ctx->getFlags().getTargetArch();
+#define SUBZERO_TARGET(X)                                                      \
+  if (Target == Target_##X)                                                    \
+    return std::unique_ptr<TargetHeaderLowering>(TargetHeader##X::create(Ctx));

[John, 2015/06/08 23:22:27]

you don't need

std::unique_ptr<>

here. Not that it causes any issues -- g++ should be able to effectively
inline-and-optimize-out the move ctors for you. Nonetheless,

return TargetHeader##X::create(Ctx);

should do the trick. Not sure, though...

[jvoung (off chromium), 2015/06/11 22:12:32]

Ah right -- Done.

+#include "llvm/Config/SZTargets.def"
+
+  llvm::report_fatal_error("Unsupported target header lowering");
+}
+
+TargetHeaderLowering::~TargetHeaderLowering() {}
+
 } // end of namespace Ice