Issue 1171543002: Use an enum for Dart bindings for Skia Paint style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1171543002: Use an enum for Dart bindings for Skia Paint style (Closed)

Created:
5 years, 6 months ago by jackson

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -26 lines)			Patch
M	sky/engine/bindings/scripts/dart_types.py	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/core.gni	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	sky/engine/core/painting/Paint.h	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	sky/engine/core/painting/Paint.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sky/engine/core/painting/Paint.idl	View	2 chunks	+1 line, -7 lines	0 comments	Download
A	sky/engine/core/painting/PaintingStyle.h	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A +	sky/engine/core/painting/PaintingStyle.cpp	View	2 chunks	+12 lines, -12 lines	0 comments	Download
A	sky/engine/core/painting/PaintingStyle.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/radio.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

jackson

5 years, 6 months ago (2015-06-05 17:12:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5b5272270d794be9b71a680a5a9f11585abe94db (presubmit successful).