Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1171493003: NaCl: Clean up some uses of native_client/src/trusted/desc/ (Closed)

Created:
5 years, 6 months ago by Mark Seaborn
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Clean up some uses of native_client/src/trusted/desc/ Switch to using the definitions from src/public/ where possible. Change DEPS to remove blanket allowances of src/trusted/desc/, and only whitelist some remaining required headers. BUG=https://code.google.com/p/nativeclient/issues/detail?id=2832 TEST=build Committed: https://crrev.com/a3f1ea0157af7cae0e6bb171f3926304797a0b37 Cr-Commit-Position: refs/heads/master@{#333057}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M components/nacl/loader/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M components/nacl/loader/nonsfi/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_main.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/nacl/renderer/plugin/DEPS View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
5 years, 6 months ago (2015-06-05 13:48:47 UTC) #2
jvoung (off chromium)
lgtm
5 years, 6 months ago (2015-06-05 15:49:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171493003/20001
5 years, 6 months ago (2015-06-05 15:51:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 15:55:42 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 15:56:31 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a3f1ea0157af7cae0e6bb171f3926304797a0b37
Cr-Commit-Position: refs/heads/master@{#333057}

Powered by Google App Engine
This is Rietveld 408576698