Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp

Issue 1171463003: Oilpan: fix build after r196513. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp
diff --git a/Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp b/Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp
index 5d585333fe492aa596dbe20e8fb636a05881b19e..15bda4aa16bbb20fb4bef375f6db038a1b46f087 100644
--- a/Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp
+++ b/Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp
@@ -626,14 +626,14 @@ const V8MethodConfiguration V8InjectedScriptHostMethods[] = {
class WeakCallbackData final {
public:
- WeakCallbackData(v8::Isolate* isolate, PassRefPtr<InjectedScriptHost> host, v8::Local<v8::Object> wrapper)
+ WeakCallbackData(v8::Isolate* isolate, PassRefPtrWillBeRawPtr<InjectedScriptHost> host, v8::Local<v8::Object> wrapper)
: m_host(host)
, m_persistent(isolate, wrapper)
{
m_persistent.SetWeak(this, &WeakCallbackData::weakCallback, v8::WeakCallbackType::kParameter);
}
- RefPtr<InjectedScriptHost> m_host;
+ RefPtrWillBePersistent<InjectedScriptHost> m_host;
sof 2015/06/04 21:44:16 This could be too strong a reference to keep aroun
private:
static void weakCallback(const v8::WeakCallbackInfo<WeakCallbackData>& info)
@@ -663,9 +663,9 @@ v8::Local<v8::FunctionTemplate> V8InjectedScriptHost::createWrapperTemplate(v8::
return functionTemplate;
}
-v8::Local<v8::Object> V8InjectedScriptHost::wrap(v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> constructorTemplate, PassRefPtr<InjectedScriptHost> host)
+v8::Local<v8::Object> V8InjectedScriptHost::wrap(v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> constructorTemplate, PassRefPtrWillBeRawPtr<InjectedScriptHost> host)
{
- RefPtr<InjectedScriptHost> impl(host);
+ RefPtrWillBeRawPtr<InjectedScriptHost> impl(host);
v8::Local<v8::Function> function;
if (!constructorTemplate->GetFunction(isolate->GetCurrentContext()).ToLocal(&function))
return v8::Local<v8::Object>();

Powered by Google App Engine
This is Rietveld 408576698