Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 1171423002: Oilpan: V8 major GC should schedule an idle GC if IDLE_GC is enabled (Closed)

Created:
4 years, 10 months ago by haraken
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, peria
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: V8 major GC should schedule an idle GC if IDLE_GC is enabled I was wondering why I sometimes observe precise GCs on non-oilpan builds where IDLE_GC is enabled. If IDLE_GC is enabled, precise GCs must not run. This CL fixes the issue. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/bindings/core/v8/V8GCController.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
haraken
PTAL
4 years, 10 months ago (2015-06-10 08:30:05 UTC) #2
peria
This CL itself LGTM. Please check if there are no other ENABLE(OILPAN)'s to replace with ...
4 years, 10 months ago (2015-06-10 08:36:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171423002/1
4 years, 10 months ago (2015-06-10 09:38:03 UTC) #5
haraken
> Please check if there are no other ENABLE(OILPAN)'s to replace with > ENABLE(LAZY_SWEEPING) or ...
4 years, 10 months ago (2015-06-10 09:39:23 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 11:40:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196858

Powered by Google App Engine
This is Rietveld 408576698