Issue 1171363002: Fix null pointer dereference in ChromeClientImpl::openBeforeUnloadConfirmPanelDelegate.

Issue 1171363002: Fix null pointer dereference in ChromeClientImpl::openBeforeUnloadConfirmPanelDelegate. (Closed)

Created:
4 years, 10 months ago by tkent

Modified:
4 years, 10 months ago

Reviewers:
yosin_UTC9

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Fix null pointer dereference in ChromeClientImpl::openBeforeUnloadConfirmPanelDelegate. If we have no frame, we don't need to open the dialog. BUG=497655 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196839

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -2 lines)			Patch
A	LayoutTests/fast/events/before-unload-crash.html	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/events/before-unload-crash-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/ChromeClient.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171363002/20001

4 years, 10 months ago (2015-06-10 06:33:50 UTC) #6

yosin_UTC9

mac bot failure is inspector/tracing/decode-resize.html It doesn't relate to this patch.

4 years, 10 months ago (2015-06-10 06:34:34 UTC) #7

commit-bot: I haz the power

4 years, 10 months ago (2015-06-10 07:03:11 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196839