Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1171343002: Fix history for reader mode (Closed)

Created:
5 years, 6 months ago by mdjones
Modified:
5 years, 6 months ago
Reviewers:
aruslan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix history for reader mode When entering reader mode, it was possible to get into a state where the distilled page would have a pending history entry and would not have the rest of the history merged. This change moves the history merge to before a new entry is set in the distilled web contents. BUG=498576 Committed: https://crrev.com/06c20e773985a26bcadf35623671514e01f2234a Cr-Commit-Position: refs/heads/master@{#333739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java_staging/src/org/chromium/chrome/browser/dom_distiller/ReaderModePanel.java View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mdjones
5 years, 6 months ago (2015-06-10 00:58:55 UTC) #2
aruslan
lgtm
5 years, 6 months ago (2015-06-10 01:07:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171343002/1
5 years, 6 months ago (2015-06-10 15:28:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 15:48:23 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 15:49:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06c20e773985a26bcadf35623671514e01f2234a
Cr-Commit-Position: refs/heads/master@{#333739}

Powered by Google App Engine
This is Rietveld 408576698