Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2265)

Unified Diff: components/url_formatter.gypi

Issue 1171333003: Move net::FormatUrl and friends outside of //net and into //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile fixes following rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/url_formatter.gypi
diff --git a/components/url_fixer.gypi b/components/url_formatter.gypi
similarity index 54%
copy from components/url_fixer.gypi
copy to components/url_formatter.gypi
index 917e9d77d743ca4563f5cb00d0624dc4f56f9232..1e905686e65f18ab06806b01d471d6b7736d3ab1 100644
--- a/components/url_fixer.gypi
+++ b/components/url_formatter.gypi
@@ -1,12 +1,12 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
+# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'targets': [
{
- # GN version: //components/url_fixer
- 'target_name': 'url_fixer',
+ # GN version: //components/url_formatter
+ 'target_name': 'url_formatter',
'type': 'static_library',
'include_dirs': [
'..',
@@ -14,14 +14,17 @@
'dependencies': [
'../base/base.gyp:base',
'../net/net.gyp:net',
+ '../third_party/icu/icu.gyp:icui18n',
+ '../third_party/icu/icu.gyp:icuuc',
+ '../url/url.gyp:url_lib',
],
'sources': [
# Note: sources list duplicated in GN build.
- 'url_fixer/url_fixer.cc',
- 'url_fixer/url_fixer.h',
+ 'url_formatter/url_formatter.cc',
+ 'url_formatter/url_formatter.h',
],
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- 'msvs_disabled_warnings': [4267, ],
+ # 'msvs_disabled_warnings': [4267, ],
},
],
}

Powered by Google App Engine
This is Rietveld 408576698