chrome/browser/extensions/extension_tab_util.cc - Issue 1171333003: Move net::FormatUrl and friends outside of //net and into //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 1171333003: Move net::FormatUrl and friends outside of //net and into //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase again now that CQ is fixed Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/settings_private/prefs_util.cc ('k') | chrome/browser/geolocation/geolocation_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_tab_util.cc

diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc

index 384c94d02d22ec80fbcbd8b740115e7a2e445dc8..22a2dea8a84f6fca5f7b25e55914711d22b40024 100644

--- a/chrome/browser/extensions/extension_tab_util.cc

+++ b/chrome/browser/extensions/extension_tab_util.cc

@@ -25,7 +25,7 @@

#include "chrome/browser/ui/tabs/tab_utils.h"

#include "chrome/common/extensions/api/tabs.h"

#include "chrome/common/url_constants.h"

-#include "components/url_fixer/url_fixer.h"

+#include "components/url_formatter/url_fixer.h"

#include "content/public/browser/favicon_status.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/web_contents.h"

@@ -551,7 +551,7 @@ bool ExtensionTabUtil::IsKillURL(const GURL& url) {

// Check a fixed-up URL, to normalize the scheme and parse hosts correctly.

GURL fixed_url =

- url_fixer::FixupURL(url.possibly_invalid_spec(), std::string());

+ url_formatter::FixupURL(url.possibly_invalid_spec(), std::string());

if (!fixed_url.SchemeIs(content::kChromeUIScheme))

return false;