chrome/browser/ui/search_engines/edit_search_engine_controller.cc - Issue 1171333003: Move net::FormatUrl and friends outside of //net and into //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search_engines/edit_search_engine_controller.cc

Issue 1171333003: Move net::FormatUrl and friends outside of //net and into //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fold in secure_display to url_formatter Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_view_utils.cc ('k') | chrome/browser/ui/startup/startup_browser_creator.cc » ('j') | components/url_formatter/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search_engines/edit_search_engine_controller.cc

diff --git a/chrome/browser/ui/search_engines/edit_search_engine_controller.cc b/chrome/browser/ui/search_engines/edit_search_engine_controller.cc

index 29b457472e462e10ad61ae8267fc885ef50dfaf6..126af58d01afe94b70b0d82bd18ca0fcf0126a9c 100644

--- a/chrome/browser/ui/search_engines/edit_search_engine_controller.cc

+++ b/chrome/browser/ui/search_engines/edit_search_engine_controller.cc

@@ -10,7 +10,7 @@

#include "chrome/browser/search_engines/template_url_service_factory.h"

#include "components/search_engines/template_url.h"

#include "components/search_engines/template_url_service.h"

-#include "components/url_fixer/url_fixer.h"

+#include "components/url_formatter/url_fixer.h"

#include "content/public/browser/user_metrics.h"

#include "url/gurl.h"

@@ -142,7 +142,7 @@ std::string EditSearchEngineController::GetFixedUpURL(

TemplateURLRef::SearchTermsArgs(base::ASCIIToUTF16("x")),

TemplateURLServiceFactory::GetForProfile(profile_)->search_terms_data()));

url::Parsed parts;

- std::string scheme(url_fixer::SegmentURL(expanded_url, &parts));

+ std::string scheme(url_formatter::SegmentURL(expanded_url, &parts));

if (!parts.scheme.is_valid())

url.insert(0, scheme + "://");