Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: chrome/browser/ui/cocoa/status_bubble_mac.mm

Issue 1171333003: Move net::FormatUrl and friends outside of //net and into //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile fixes following rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/status_bubble_mac.h" 5 #include "chrome/browser/ui/cocoa/status_bubble_mac.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/debug/stack_trace.h" 11 #include "base/debug/stack_trace.h"
12 #include "base/mac/mac_util.h" 12 #include "base/mac/mac_util.h"
13 #include "base/mac/scoped_block.h" 13 #include "base/mac/scoped_block.h"
14 #include "base/mac/sdk_forward_declarations.h" 14 #include "base/mac/sdk_forward_declarations.h"
15 #include "base/message_loop/message_loop.h" 15 #include "base/message_loop/message_loop.h"
16 #include "base/strings/string_util.h" 16 #include "base/strings/string_util.h"
17 #include "base/strings/sys_string_conversions.h" 17 #include "base/strings/sys_string_conversions.h"
18 #include "base/strings/utf_string_conversions.h" 18 #include "base/strings/utf_string_conversions.h"
19 #import "chrome/browser/ui/cocoa/bubble_view.h" 19 #import "chrome/browser/ui/cocoa/bubble_view.h"
20 #include "chrome/browser/ui/elide_url.h" 20 #include "chrome/browser/ui/elide_url.h"
21 #include "net/base/net_util.h" 21 #include "components/url_formatter/url_formatter.h"
22 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h " 22 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h "
23 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSBezierPath+RoundRect .h" 23 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSBezierPath+RoundRect .h"
24 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSColor+Luminance.h" 24 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSColor+Luminance.h"
25 #include "ui/base/cocoa/window_size_constants.h" 25 #include "ui/base/cocoa/window_size_constants.h"
26 #include "ui/gfx/font_list.h" 26 #include "ui/gfx/font_list.h"
27 #include "ui/gfx/geometry/point.h" 27 #include "ui/gfx/geometry/point.h"
28 #include "ui/gfx/text_elider.h" 28 #include "ui/gfx/text_elider.h"
29 #include "ui/gfx/text_utils.h" 29 #include "ui/gfx/text_utils.h"
30 30
31 namespace { 31 namespace {
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 kTextPadding); 227 kTextPadding);
228 228
229 // Scale from view to window coordinates before eliding URL string. 229 // Scale from view to window coordinates before eliding URL string.
230 NSSize scaled_width = NSMakeSize(text_width, 0); 230 NSSize scaled_width = NSMakeSize(text_width, 0);
231 scaled_width = [[parent_ contentView] convertSize:scaled_width fromView:nil]; 231 scaled_width = [[parent_ contentView] convertSize:scaled_width fromView:nil];
232 text_width = static_cast<int>(scaled_width.width); 232 text_width = static_cast<int>(scaled_width.width);
233 NSFont* font = [[window_ contentView] font]; 233 NSFont* font = [[window_ contentView] font];
234 gfx::FontList font_list_chr( 234 gfx::FontList font_list_chr(
235 gfx::Font(base::SysNSStringToUTF8([font fontName]), [font pointSize])); 235 gfx::Font(base::SysNSStringToUTF8([font fontName]), [font pointSize]));
236 236
237 base::string16 original_url_text = net::FormatUrl(url, languages); 237 base::string16 original_url_text = url_formatter::FormatUrl(url, languages);
238 base::string16 status = 238 base::string16 status =
239 ElideUrl(url, font_list_chr, text_width, languages); 239 ElideUrl(url, font_list_chr, text_width, languages);
240 240
241 SetText(status, true); 241 SetText(status, true);
242 242
243 // In testing, don't use animation. When ExpandBubble is tested, it is 243 // In testing, don't use animation. When ExpandBubble is tested, it is
244 // called explicitly. 244 // called explicitly.
245 if (immediate_) 245 if (immediate_)
246 return; 246 return;
247 else 247 else
(...skipping 600 matching lines...) Expand 10 before | Expand all | Expand 10 after
848 } 848 }
849 849
850 // Round the top corners when the bubble is below the parent window. 850 // Round the top corners when the bubble is below the parent window.
851 if (NSMinY(window_frame) < NSMinY(parent_frame)) { 851 if (NSMinY(window_frame) < NSMinY(parent_frame)) {
852 corner_flags |= kRoundedTopLeftCorner | kRoundedTopRightCorner; 852 corner_flags |= kRoundedTopLeftCorner | kRoundedTopRightCorner;
853 } 853 }
854 } 854 }
855 855
856 return corner_flags; 856 return corner_flags;
857 } 857 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698