Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: components/url_formatter/BUILD.gn

Issue 1171333003: Move net::FormatUrl and friends outside of //net and into //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android checkdeps Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/url_fixer/url_fixer_unittest.cc ('k') | components/url_formatter/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 static_library("url_formatter") {
brettw 2015/08/06 22:25:50 This should be a source_set too.
6 sources = [
7 "elide_url.cc",
8 "elide_url.h",
9 "url_fixer.cc",
10 "url_fixer.h",
11 "url_formatter.cc",
12 "url_formatter.h",
13 ]
14
15 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
16 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
17
18 deps = [
19 "//base",
20 "//third_party/icu",
21 "//net",
22 "//ui/gfx",
23 "//url",
24 ]
25
26 if (is_android) {
27 deps -= [ "//ui/gfx" ]
brettw 2015/08/06 22:25:50 In GYP this is how you would do it, but in GN I pr
28 }
29 }
30
31 source_set("unit_tests") {
32 testonly = true
33 sources = [
34 "elide_url_unittest.cc",
35 "url_fixer_unittest.cc",
36 "url_formatter_unittest.cc",
37 ]
38
39 deps = [
40 "//base",
41 "//net",
42 "//testing/gtest",
43 "//ui/gfx",
44 "//url",
45 ":url_formatter",
brettw 2015/08/06 22:25:50 This goes first.
46 ]
47
48 if (is_android) {
49 deps -= [ "//ui/gfx" ]
50 }
51 }
OLDNEW
« no previous file with comments | « components/url_fixer/url_fixer_unittest.cc ('k') | components/url_formatter/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698