Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(116)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1171323003: Fix unit test style in core/{dom,editing,html}/. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
kochi
CC:
blink-reviews, Yoav Weiss, blink-reviews-html_chromium.org, gavinp+prerender_chromium.org, blink-reviews-style_chromium.org, webcomponents-bugzilla_chromium.org, gasubic, sof, eae+blinkwatch, fs, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, eric.carlson_apple.com, nessy, dshwang, vcarbune.chromium, philipj_slow, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix unit test style in core/{dom,editing,html}/. BUG=498604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196836

Patch Set 1 #

Total comments: 2

Patch Set 2 : whitespace fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -206 lines) Patch
M Source/core/dom/ActiveDOMObjectTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/dom/AttrTest.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/dom/DOMImplementationTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/dom/DocumentMarkerControllerTest.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/dom/DocumentTest.cpp View 3 chunks +8 lines, -7 lines 0 comments Download
M Source/core/dom/MainThreadTaskRunnerTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/dom/NthIndexCacheTest.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M Source/core/dom/RangeTest.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/dom/TreeScopeTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/dom/shadow/ComposedTreeTraversalTest.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/core/editing/CompositionUnderlineRangeFilterTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/editing/FrameSelectionTest.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/editing/GranularityStrategyTest.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/editing/InputMethodControllerTest.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/core/editing/StyledMarkupSerializerTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/SurroundingTextTest.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/core/editing/VisibleSelectionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/TextIteratorTest.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M Source/core/html/HTMLDimensionTest.cpp View 19 chunks +24 lines, -30 lines 0 comments Download
M Source/core/html/HTMLFormControlElementTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLinkElementSizesAttributeTest.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/HTMLSelectElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/html/LinkRelAttributeTest.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M Source/core/html/TimeRangesTest.cpp View 16 chunks +19 lines, -18 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DAPITest.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DTest.cpp View 4 chunks +3 lines, -5 lines 0 comments Download
M Source/core/html/forms/FileInputTypeTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLParserThreadTest.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScannerTest.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/core/html/track/vtt/BufferedLineReaderTest.cpp View 17 chunks +18 lines, -21 lines 0 comments Download
M Source/core/html/track/vtt/VTTScannerTest.cpp View 10 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
kochi-san, would you review this please? This is super-trivial.
4 years, 10 months ago (2015-06-10 04:02:29 UTC) #2
kochi
lgtm https://codereview.chromium.org/1171323003/diff/1/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp File Source/core/html/HTMLLinkElementSizesAttributeTest.cpp (right): https://codereview.chromium.org/1171323003/diff/1/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp#newcode75 Source/core/html/HTMLLinkElementSizesAttributeTest.cpp:75: } // namespace blink nit: one space between ...
4 years, 10 months ago (2015-06-10 04:37:49 UTC) #3
tkent
Thanks! https://codereview.chromium.org/1171323003/diff/1/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp File Source/core/html/HTMLLinkElementSizesAttributeTest.cpp (right): https://codereview.chromium.org/1171323003/diff/1/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp#newcode75 Source/core/html/HTMLLinkElementSizesAttributeTest.cpp:75: } // namespace blink On 2015/06/10 04:37:48, Takayoshi ...
4 years, 10 months ago (2015-06-10 04:50:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171323003/20001
4 years, 10 months ago (2015-06-10 04:50:24 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 06:09:33 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196836

Powered by Google App Engine
This is Rietveld 408576698