Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1171293005: Revert of content: Single process support for native GpuMemoryBuffers. (Closed)

Created:
5 years, 6 months ago by kjellander_chromium
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dm-browsertests-refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of content: Single process support for native GpuMemoryBuffers. (patchset #8 id:140001 of https://codereview.chromium.org/1120873002/) Reason for revert: Breaks Mac10.6 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/3331 Original issue's description: > content: Single process support for native GpuMemoryBuffers. > > This adds single process support for IOSurface and > SurfaceTexture backed GpuMemoryBuffers. > > Also makes the SurfaceTexture code more consistent > with IOSurface code by using a singleton instead of > leaking a raw pointer. > > BUG=497559 > TEST=content_browsertests --gtest_filter=ChildThreadImplGpuMemoryBufferBrowserTests/* > > Committed: https://crrev.com/d5395d05e7f006ef9d1efaf8ec84030d24fb9fef > Cr-Commit-Position: refs/heads/master@{#333625} TBR=avi@chromium.org,dcastagna@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497559 Committed: https://crrev.com/4d0ac15c70965c05e6905e5bf144cd8decf768c7 Cr-Commit-Position: refs/heads/master@{#333696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -364 lines) Patch
M content/browser/android/browser_surface_texture_manager.h View 2 chunks +4 lines, -11 lines 0 comments Download
M content/browser/android/browser_surface_texture_manager.cc View 2 chunks +6 lines, -12 lines 0 comments Download
D content/browser/android/in_process_surface_texture_manager.h View 1 chunk +0 lines, -57 lines 0 comments Download
D content/browser/android/in_process_surface_texture_manager.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M content/browser/browser_io_surface_manager_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 4 chunks +2 lines, -14 lines 0 comments Download
D content/browser/in_process_io_surface_manager_mac.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/browser/in_process_io_surface_manager_mac.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M content/child/child_thread_impl_browsertest.cc View 5 chunks +2 lines, -94 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M content/test/content_test_suite.cc View 5 chunks +71 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kjellander_chromium
Created Revert of content: Single process support for native GpuMemoryBuffers.
5 years, 6 months ago (2015-06-10 07:33:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171293005/1
5 years, 6 months ago (2015-06-10 07:33:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 07:34:24 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 07:35:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d0ac15c70965c05e6905e5bf144cd8decf768c7
Cr-Commit-Position: refs/heads/master@{#333696}

Powered by Google App Engine
This is Rietveld 408576698