sky/sdk/lib/framework/rendering/paragraph.dart - Issue 1171273002: Move AnimatedComponent away from mirrors and towards a callback-based setter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/rendering/paragraph.dart

Issue 1171273002: Move AnimatedComponent away from mirrors and towards a callback-based setter. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/sdk/lib/framework/rendering/paragraph.dart

diff --git a/sky/sdk/lib/framework/rendering/paragraph.dart b/sky/sdk/lib/framework/rendering/paragraph.dart

index 834a53493042ab37324a413fa11ae81c28cdd01e..5daf12a1ae176716779a3e627c4355e6cf2b82f6 100644

--- a/sky/sdk/lib/framework/rendering/paragraph.dart

+++ b/sky/sdk/lib/framework/rendering/paragraph.dart

@@ -77,7 +77,7 @@ class RenderParagraph extends RenderBox {

double _getIntrinsicHeight(BoxConstraints constraints) {

_layout(constraints);

return constraints.constrainHeight(

- _applyFloatingPointHack(_layoutRoot.rootElement.height.ceilToDouble));

+ _applyFloatingPointHack(_layoutRoot.rootElement.height));

}

double getMinIntrinsicHeight(BoxConstraints constraints) {

« no previous file with comments | « sky/sdk/lib/framework/components2/popup_menu.dart ('k') | no next file » | no next file with comments »