media/base/demuxer_stream.h - Issue 1171263004: Allow setting memory limits on media::DemuxerStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/demuxer_stream.h

Issue 1171263004: Allow setting memory limits on media::DemuxerStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/demuxer_stream.h

diff --git a/media/base/demuxer_stream.h b/media/base/demuxer_stream.h

index 596ab67e83692aba287f11e6c1488a623ffee8e6..b900617bff9ddc8d7d5bdb1f5498c21e554f8c23 100644

--- a/media/base/demuxer_stream.h

+++ b/media/base/demuxer_stream.h

@@ -91,6 +91,12 @@ class MEDIA_EXPORT DemuxerStream {

virtual VideoRotation video_rotation() = 0;

+ // Get the maximum amount of data that this DemuxerStream is allowed to buffer

philipj_slow 2015/06/11 08:44:05 I suppose document the unit, bytes?

servolk 2015/06/12 00:50:48 Done.

+ virtual int GetMemoryLimit() const = 0;

+ // Set the maximum amount of data that this DemuxerStream is allowed to buffer

+ virtual void SetMemoryLimit(int memory_limit) = 0;

protected:

// Only allow concrete implementations to get deleted.

virtual ~DemuxerStream();

« no previous file with comments | « chromecast/media/cma/test/demuxer_stream_for_test.cc ('k') | media/base/fake_demuxer_stream.h » ('j') | media/base/fake_text_track_stream.cc » ('J')