Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: media/filters/source_buffer_stream.cc

Issue 1171263004: Allow setting memory limits on media::DemuxerStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merged CL that adds get/set buffer size on WMP Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/source_buffer_stream.h ('k') | media/filters/source_buffer_stream_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/source_buffer_stream.cc
diff --git a/media/filters/source_buffer_stream.cc b/media/filters/source_buffer_stream.cc
index 18a08b7501f4b640514ffffdc2845b03437aaacb..243a708e5b7ec70b1ab5e35eddee2a8421b4890a 100644
--- a/media/filters/source_buffer_stream.cc
+++ b/media/filters/source_buffer_stream.cc
@@ -594,30 +594,30 @@ void SourceBufferStream::SetConfigIds(const BufferQueue& buffers) {
void SourceBufferStream::GarbageCollectIfNeeded() {
// Compute size of |ranges_|.
- int ranges_size = 0;
+ size_t ranges_size = 0;
for (RangeList::iterator itr = ranges_.begin(); itr != ranges_.end(); ++itr)
ranges_size += (*itr)->size_in_bytes();
// Return if we're under or at the memory limit.
- if (ranges_size <= memory_limit_)
+ if (ranges_size <= GetMemoryLimit())
return;
- int bytes_to_free = ranges_size - memory_limit_;
+ size_t bytes_to_free = ranges_size - GetMemoryLimit();
DVLOG(2) << __FUNCTION__ << " " << GetStreamTypeName() << ": Before GC"
<< " ranges_size=" << ranges_size
<< " ranges_=" << RangesToString(ranges_)
- << " memory_limit_=" << memory_limit_;
+ << " GetMemoryLimit()=" << GetMemoryLimit();
// Begin deleting after the last appended buffer.
- int bytes_freed = FreeBuffersAfterLastAppended(bytes_to_free);
+ size_t bytes_freed = FreeBuffersAfterLastAppended(bytes_to_free);
// Begin deleting from the front.
- if (bytes_to_free - bytes_freed > 0)
+ if (bytes_freed < bytes_to_free)
bytes_freed += FreeBuffers(bytes_to_free - bytes_freed, false);
// Begin deleting from the back.
- if (bytes_to_free - bytes_freed > 0)
+ if (bytes_freed < bytes_to_free)
bytes_freed += FreeBuffers(bytes_to_free - bytes_freed, true);
DVLOG(2) << __FUNCTION__ << " " << GetStreamTypeName() << ": After GC"
« no previous file with comments | « media/filters/source_buffer_stream.h ('k') | media/filters/source_buffer_stream_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698