Allow setting memory limits on media::DemuxerStream

media/filters/source_buffer_stream.h

Index: media/filters/source_buffer_stream.h
diff --git a/media/filters/source_buffer_stream.h b/media/filters/source_buffer_stream.h
index 0e70ff79c9da405eca587c930210a913e9346805..2570c274805229a2276fc4861c0c577b5d5f5131 100644
--- a/media/filters/source_buffer_stream.h
+++ b/media/filters/source_buffer_stream.h
@@ -142,7 +142,11 @@ class MEDIA_EXPORT SourceBufferStream {
   // yet.
   base::TimeDelta GetMaxInterbufferDistance() const;
 
-  void set_memory_limit(int memory_limit) {
+  size_t GetMemoryLimit() const {

[ddorwin, 2015/06/17 21:02:16]

Memory limit for what? Maximum source buffer size? That's what's currently
implied, but I don't think that's accurate. It appears to be the maximum byte
range cache size or something like that.

[servolk, 2015/06/17 22:13:48]

Yeah, I guess you can call it "maximum byte cache range size". Note that the
terminology here (the "memory limit") wasn't introduced by me, it was introduced
long time ago by somebody else in a different CL. I'm just renaming the method
to make it's name more consistent with what I'm adding in media::DemuxerStream
interface in this CL. I can rename it to something else, if you prefer, but I
though the old terminology was fine and reasonably understandable.

[ddorwin, 2015/06/20 01:50:26]

Previously, the name followed the accessor style. Why did you change that?
https://www.chromium.org/developers/coding-style#TOC-Inline-functions

If not following that style, we should definitely be clearer. Even as an
accessor, we might consider updating the naming, though possibly in a separate
CL since we'd need to change all uses of this member.

+    return memory_limit_;
+  }
+
+  void SetMemoryLimit(size_t memory_limit) {
     memory_limit_ = memory_limit;
   }
 
@@ -396,7 +400,7 @@ class MEDIA_EXPORT SourceBufferStream {
   base::TimeDelta max_interbuffer_distance_;
 
   // The maximum amount of data in bytes the stream will keep in memory.
-  int memory_limit_;
+  size_t memory_limit_;
 
   // Indicates that a kConfigChanged status has been reported by GetNextBuffer()
   // and GetCurrentXXXDecoderConfig() must be called to update the current