Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: media/filters/ffmpeg_demuxer.h

Issue 1171263004: Allow setting memory limits on media::DemuxerStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Include logging.h for NOTIMPLEMENTED definition Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/ffmpeg_demuxer.h
diff --git a/media/filters/ffmpeg_demuxer.h b/media/filters/ffmpeg_demuxer.h
index 329364ff12391938c5903987c93e6f8849c27f6b..cf0bf86c38a7a05f541f39c960c798899a11df92 100644
--- a/media/filters/ffmpeg_demuxer.h
+++ b/media/filters/ffmpeg_demuxer.h
@@ -95,6 +95,14 @@ class FFmpegDemuxerStream : public DemuxerStream {
VideoDecoderConfig video_decoder_config() override;
VideoRotation video_rotation() override;
+ // TODO(servolk): Implement better memory limit control for FFMpegDemuxer,
+ // currently is has a hard-coded limit of 150Mb across all streams (see
+ // IsMaxMemoryUsageReached and crbug.com/343304).
+ // Also FFmpegDemuxer is always used with media::BufferDataSource, perhaps
+ // we should control buffer size via that for FFmpeg.
+ //int GetMemoryLimit() const override;
+ //void SetMemoryLimit(int memory_limit) override;
+
void SetLiveness(Liveness liveness);
// Returns the range of buffered data in this stream.

Powered by Google App Engine
This is Rietveld 408576698