Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: media/filters/chunk_demuxer.h

Issue 1171263004: Allow setting memory limits on media::DemuxerStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Include logging.h for NOTIMPLEMENTED definition Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/chunk_demuxer.h
diff --git a/media/filters/chunk_demuxer.h b/media/filters/chunk_demuxer.h
index 9ee3526ff5a5f1b41e95ac467111468d93ca3e08..272720ada5bc188e46b296e4f96a5d96b68bc216 100644
--- a/media/filters/chunk_demuxer.h
+++ b/media/filters/chunk_demuxer.h
@@ -88,16 +88,13 @@ class MEDIA_EXPORT ChunkDemuxerStream : public DemuxerStream {
VideoDecoderConfig video_decoder_config() override;
bool SupportsConfigChanges() override;
VideoRotation video_rotation() override;
+ int GetMemoryLimit() const override;
+ void SetMemoryLimit(int memory_limit) override;
// Returns the text track configuration. It is an error to call this method
// if type() != TEXT.
TextTrackConfig text_track_config();
- // Sets the memory limit, in bytes, on the SourceBufferStream.
- void set_memory_limit(int memory_limit) {
- stream_->set_memory_limit(memory_limit);
- }
-
bool supports_partial_append_window_trimming() const {
return partial_append_window_trimming_enabled_;
}
@@ -273,11 +270,6 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
void Shutdown();
- // Sets the memory limit on each stream of a specific type.
- // |memory_limit| is the maximum number of bytes each stream of type |type|
- // is allowed to hold in its buffer.
- void SetMemoryLimits(DemuxerStream::Type type, int memory_limit);
-
// Returns the ranges representing the buffered data in the demuxer.
// TODO(wolenetz): Remove this method once MediaSourceDelegate no longer
// requires it for doing hack browser seeks to I-frame on Android. See

Powered by Google App Engine
This is Rietveld 408576698