Fixing Firefox 21+ password import

chrome/common/importer/firefox_importer_utils.cc

Index: chrome/common/importer/firefox_importer_utils.cc
diff --git a/chrome/common/importer/firefox_importer_utils.cc b/chrome/common/importer/firefox_importer_utils.cc
index 4f6a2019e781551b516cdde924b5aca31f755e1e..cee249aa2d72117babd7ecdd3d1b604dfb66d8c8 100644
--- a/chrome/common/importer/firefox_importer_utils.cc
+++ b/chrome/common/importer/firefox_importer_utils.cc
@@ -115,7 +115,7 @@ bool GetFirefoxVersionAndPathFromProfile(const base::FilePath& profile_path,
       if (key == "LastVersion") {
         base::StringToInt(line.substr(equal + 1), version);
         ret = true;
-      } else if (key == "LastAppDir") {
+      } else if (key == "LastPlatformDir") {

[Ilya Sherman, 2013/12/17 23:04:14]

Two questions:

(1) Does this work for all versions of Firefox, or just newer ones?
(2) Does this work for all platforms, or just Mac?

[mpawlowski, 2013/12/18 08:50:29]

I've looked at Firefox's sources, and the code that sets those variables hasn't
been touched since August 2005
(https://github.com/mozilla/gecko-dev/blame/master/toolkit/xre/nsAppRunner.cpp
search page for "LastPlatformDir") which is about when Firefox 1.0.6 was
released :) This is the only place in their codebase where "LastPlatformDir" and
"LastAppDir" are used, so it's safe to assume this logic is cross-platform. I've
checked several Firefox versions I had on Mac and Windows, all have this.

As for the effect of this change on Chrome platforms, everywhere I checked
(Windows, Ubuntu, Mac) the actual FF libraries are under LastPlatformDir and
LastAppDir points to LastPlatformDir/browser, so it's the same as observed on
Mac. This should be a beneficial change everywhere. However, on Windows we use
the registry to find the installation path, not this ini file, and on Ubuntu we
seem to be using the system NSS decryptor and we ignore Firefox's installation
altogether. So my fix, while valid everywhere, will go unnoticed on those
platforms - they haven't been affected by Mozilla's changes and won't be
affected by my fix.

[Ilya Sherman, 2013/12/18 20:04:21]

Lovely.  Thanks for doing the deep investigation there!

[jeremy, 2013/12/18 20:16:08]

I understand that this matches what we want and hasn't changed in a very long
time, but what is the semantic meaning of LastPlatformDir?

IMHO if we aren't using this for the intended purpose, it makes more sense to
find the .app ourselves in the path and build up the path to the library from
there.  I just feel that it's more robust than relying on things not changing.

         // TODO(evanm): If the path in question isn't convertible to
         // UTF-8, what does Firefox do?  If it puts raw bytes in the
         // file, we could go straight from bytes -> filepath;