Fixing Firefox 21+ password import

chrome/common/importer/firefox_importer_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/importer/firefox_importer_utils.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 
@@ skipping 97 matching lines @@
   for (size_t i = 0; i < lines.size(); ++i) {
     const std::string& line = lines[i];
     if (line.empty() || line[0] == '#' || line[0] == ';')
       continue;
     size_t equal = line.find('=');
     if (equal != std::string::npos) {
       std::string key = line.substr(0, equal);
       if (key == "LastVersion") {
         base::StringToInt(line.substr(equal + 1), version);
         ret = true;
-      } else if (key == "LastAppDir") {
+      } else if (key == "LastPlatformDir") {

[jeremy, 2013/12/17 11:48:09]

Do you know what the actual semantic meaning of this key is?

My concern is just that we're using this value because it happens to contain the
directory we need and not because of it's real meaning?

My suggestion would be for the caller to look at the value of LastAppDir, search
for Firefox.app manually and build up the path from there rather than switching
to a key which happens to contain the directory we're looking for.

[mpawlowski, 2013/12/17 12:31:25]

What if someone renames Firefox.app? From what I can tell by looking at
Firefox's code, LastPlatformDir is the folder in which the XUL runtime is stored
and LastAppDir is the folder with omni.ja - the package with resources, UI
definitions etc., the actual "app". The question which one should be used to
find what we need for importing is open but IMHO we don't have any control over
this and Mozilla seems to move stuff about. We should use whatever works and
worry again when it breaks, we won't be able to foresee what kind of
rearrangement they'll come up with next, no assumption is guaranteed to be
correct. I could change this to any arbitrary method of arriving at
Firefox.app/Content/MacOS but it won't guarantee they don't move those libs to
Firefox.app/Content/MacOS/Libraries next week.

         // TODO(evanm): If the path in question isn't convertible to
         // UTF-8, what does Firefox do?  If it puts raw bytes in the
         // file, we could go straight from bytes -> filepath;
         // otherwise, we're out of luck here.
         *app_path = base::FilePath::FromUTF8Unsafe(line.substr(equal + 1));
       }
     }
   }
   return ret;
 }
@@ skipping 148 matching lines @@
         }
       }
     }
   }
 
   StringToLowerASCII(&branding_name);
   if (branding_name.find("iceweasel") != std::string::npos)
     return l10n_util::GetStringUTF16(IDS_IMPORT_FROM_ICEWEASEL);
   return l10n_util::GetStringUTF16(IDS_IMPORT_FROM_FIREFOX);
 }