Source/core/svg/SVGAnimationElement.cpp - Issue 1171223004: Sanitize SVG animation attributes which could set JavaScript URL values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAnimationElement.cpp

Issue 1171223004: Sanitize SVG animation attributes which could set JavaScript URL values. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Thanks for feedback. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGAnimationElement.cpp

diff --git a/Source/core/svg/SVGAnimationElement.cpp b/Source/core/svg/SVGAnimationElement.cpp

index 4b59a4a2ed6bbea2eae633a3477221fa3a37659c..ae647a9033ccdadfa0c0ae3f296087e838398711 100644

--- a/Source/core/svg/SVGAnimationElement.cpp

+++ b/Source/core/svg/SVGAnimationElement.cpp

@@ -52,7 +52,7 @@ SVGAnimationElement::SVGAnimationElement(const QualifiedName& tagName, Document&

UseCounter::count(document, UseCounter::SVGAnimationElement);

}

-static bool parseValues(const String& value, Vector<String>& result)

+bool SVGAnimationElement::parseValues(const String& value, Vector<String>& result)

{

// Per the SMIL specification, leading and trailing white space,

// and white space before and after semicolon separators, is allowed and will be ignored.