Add stubs in platform_macos and file_system_watcher_macos for building the same

Add stubs in platform_macos and file_system_watcher_macos for building the same
on iOS

[Chinmay, 2015-06-09 20:55:32]

chinmaygarde@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2015-06-09 21:20:04]

https://codereview.chromium.org/1171223003/diff/1/runtime/bin/file_system_wat...
File runtime/bin/file_system_watcher_macos.cc (right):

https://codereview.chromium.org/1171223003/diff/1/runtime/bin/file_system_wat...
runtime/bin/file_system_watcher_macos.cc:8: #if defined(TARGET_OS_MACOS) &&
!defined(TARGET_OS_IOS)
This will not work on the regular Dart builds as they do not filter source files
and thus would always include the above line.

Preferable in this case would be:

#include "platform/globals.h"

#if defined(TARGET_OS_MACOS)
#include "bin/file_system_watcher.h"

#if !defined(TARGET_OS_IOS)

... original code ...

#else  // !defined(TARGET_OS_IOS)

... new stubbed out code ...

#endif // !defined(TARGET_OS_IOS)

https://codereview.chromium.org/1171223003/diff/1/runtime/bin/platform_macos.cc
File runtime/bin/platform_macos.cc (right):

https://codereview.chromium.org/1171223003/diff/1/runtime/bin/platform_macos....
runtime/bin/platform_macos.cc:6: #if defined(TARGET_OS_MACOS) ||
defined(TARGET_OS_IOS)
Please note that TARGET_OS_IOS also automatically means that TARGET_OS_MACOS is
defined. I am fine either way here, even if it is a bit redundant.

https://codereview.chromium.org/1171223003/diff/1/runtime/bin/platform_macos....
runtime/bin/platform_macos.cc:63: return NULL;
Is there really no way to access environment variables on iOS?

[Ivan Posva, 2015-06-12 23:41:13]

LGTM

Feel free to change the TODO about the environment to (iposva).

-Ivan

[Chinmay, 2015-06-12 23:51:49]

The CQ bit was checked by chinmaygarde@google.com

[Chinmay, 2015-06-12 23:51:49]

The patchset sent to the CQ was uploaded after l-g-t-m from iposva@google.com
Link to the patchset: https://codereview.chromium.org/1171223003/#ps40001
(title: "Address CL concerns")

[commit-bot: I haz the power, 2015-06-12 23:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 23:55:03]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Ivan Posva, 2015-06-13 14:23:12]

On 2015/06/12 23:55:03, commit-bot: I haz the power wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

Landed as https://codereview.chromium.org/1174343006/

-Ivan