ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm - Issue 1171203004: Correct iOS build for latest Xcode beta.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm

Issue 1171203004: Correct iOS build for latest Xcode beta. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm

diff --git a/ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm b/ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm

index dd15a3d9949bea02cd2f5ba6759cb191c0001eae..b5d995b89cd76f1d4a2bd60c24613134892dec25 100644

--- a/ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm

+++ b/ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm

@@ -72,7 +72,7 @@

[_webView loadData:data

MIMEType:@"application/pdf"

textEncodingName:@"utf-8"

- baseURL:nil];

+ baseURL:[[NSURL alloc] initWithString:@""]];

shreyasv1 2015/06/10 15:14:34 This is a memory leak? autorelease or wrap in a sc

justincohen 2015/06/10 15:21:11 Done

}

- (void)evaluateJavaScript:(NSString*)script