Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: ios/net/request_tracker.mm

Issue 1171203004: Correct iOS build for latest Xcode beta. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/net/ios_net.gyp ('k') | ios/public/test/test_updatable_resource_provider.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/net/request_tracker.mm
diff --git a/ios/net/request_tracker.mm b/ios/net/request_tracker.mm
index 6eb21c3f7e231177b7b23987332a3e684a2bc8be..a4cfa5476e481550db23888c013e981630377bbd 100644
--- a/ios/net/request_tracker.mm
+++ b/ios/net/request_tracker.mm
@@ -34,7 +34,11 @@ class GlobalNetworkClientFactories {
// Adds a factory.
void AddFactory(CRNForwardingNetworkClientFactory* factory) {
DCHECK(thread_checker_.CalledOnValidThread());
- DCHECK_EQ(NSNotFound, [factories_ indexOfObject:factory]);
+ // TODO(justincohen): Cast indexOfObject to work around Xcode beta bugs.
+ // Revisit in future betas where hopefully these types match again.
+ // crbug.com/498825
+ DCHECK_EQ(NSNotFound,
+ static_cast<NSInteger>([factories_ indexOfObject:factory]));
DCHECK(!IsSelectorOverriden(factory, @selector(clientHandlingRequest:)));
DCHECK(!IsSelectorOverriden(factory,
@selector(clientHandlingResponse:request:)));
« no previous file with comments | « ios/net/ios_net.gyp ('k') | ios/public/test/test_updatable_resource_provider.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698