Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm

Issue 1171203004: Correct iOS build for latest Xcode beta. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm
diff --git a/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm b/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm
index db1cd90a464c81ae9bc7b483e462c876e11361d9..aec2fa0eaca342481379df5074fa1c1764ea9049 100644
--- a/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm
+++ b/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm
@@ -68,6 +68,9 @@ TEST_F(WKWebViewConfigurationProviderTest, ConfigurationOwnerhip) {
other_provider.GetWebViewConfiguration().processPool);
}
+#if 0
rohitrao (ping after 24h) 2015/06/10 16:18:22 We can check the current SDK version instead of #i
justincohen 2015/06/10 16:33:36 shreyasv is OK with fixing it shortly. It's a sma
+// TODO(shreyasv) Disabled for usaging of nil on latest Xcode beta.
+// crbug.com/498841
// Tests that internal configuration object can not be changed by clients.
TEST_F(WKWebViewConfigurationProviderTest, ConfigurationProtection) {
CR_TEST_REQUIRES_WK_WEB_VIEW();
@@ -93,6 +96,7 @@ TEST_F(WKWebViewConfigurationProviderTest, ConfigurationProtection) {
EXPECT_EQ(userContentController.get(),
provider.GetWebViewConfiguration().userContentController);
}
+#endif
// Tests that |HasWebViewConfiguration| returns false by default.
TEST_F(WKWebViewConfigurationProviderTest, NoConfigurationByDefault) {

Powered by Google App Engine
This is Rietveld 408576698