Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm

Issue 1171203004: Correct iOS build for latest Xcode beta. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove test again Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ios/web/crw_browsing_data_store_unittest.mm ('K') | « ios/web/web_state/js/crw_js_early_script_manager_unittest.mm ('k') | ios/web/web_state/ui/crw_web_controller_unittest.mm » ('j') | ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm
diff --git a/ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm b/ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm
index dd15a3d9949bea02cd2f5ba6759cb191c0001eae..acfd5b37cca4acb6725cff7acf0a69e58671d3e4 100644
--- a/ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm
+++ b/ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm
@@ -72,7 +72,7 @@
[_webView loadData:data
MIMEType:@"application/pdf"
textEncodingName:@"utf-8"
- baseURL:nil];
+ baseURL:[[[NSURL alloc] initWithString:@""] autorelease]];
droger 2015/06/10 15:59:10 why not [NSURL URLWithString:@""] ?
justincohen 2015/06/10 16:02:25 Done.
}
- (void)evaluateJavaScript:(NSString*)script
« ios/web/crw_browsing_data_store_unittest.mm ('K') | « ios/web/web_state/js/crw_js_early_script_manager_unittest.mm ('k') | ios/web/web_state/ui/crw_web_controller_unittest.mm » ('j') | ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698