ios/net/empty_nsurlcache.h - Issue 1171203004: Correct iOS build for latest Xcode beta.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/net/empty_nsurlcache.h

Issue 1171203004: Correct iOS build for latest Xcode beta. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove test again Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_NET_EMPTY_NSURLCACHE_H_

	6 #define IOS_NET_EMPTY_NSURLCACHE_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 @interface EmptyNSURLCache : NSURLCache
	droger 2015/06/10 15:59:10 Add a comment. I suggest something like: // Dummy Add a comment. I suggest something like: // Dummy NSURLCache implementation that does not cache anything. justincohen 2015/06/10 16:02:25 Done. Show quoted text On 2015/06/10 15:59:10, droger wrote: > Add a comment. I suggest something like: > > // Dummy NSURLCache implementation that does not cache anything. Done.
	11 - (NSCachedURLResponse*)cachedResponseForRequest:
	droger 2015/06/10 15:59:10 Optional: remove this. I don't know exactly what i Optional: remove this. I don't know exactly what is the recommended style, but I think that in most case we don't redeclare in headers the methods that are inherited. justincohen 2015/06/10 16:02:25 Done. Show quoted text On 2015/06/10 15:59:10, droger wrote: > Optional: > remove this. I don't know exactly what is the recommended style, but I think > that in most case we don't redeclare in headers the methods that are inherited. Done.
	12 (NSURLRequest*)request;

	13 @end

	14

	15 #endif // IOS_NET_EMPTY_NSURLCACHE_H_

OLD	NEW