Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1171183002: Use struct AlternativeService in OnAltSvc() and OnSpdyAltSvc() methods. (Closed)

Created:
5 years, 6 months ago by Bence
Modified:
5 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use struct AlternativeService in OnAltSvc() and OnSpdyAltSvc() methods. Use struct AlternativeService parameter in SpdyFramerVisitorInterface::OnAltSvc() and SpdyDispatcher::OnSpdyAltSvc() methods. This is in preparation for handling multiple alternative services that a single HTTP/1.1 header field or HTTP/2 frame can carry. This CL lands server change 94293057 by bnc. BUG=392575 Committed: https://crrev.com/d172e66b4c118176070cabb53afc2f9bff637c1b Cr-Commit-Position: refs/heads/master@{#333717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -143 lines) Patch
M net/quic/quic_headers_stream_test.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.h View 1 chunk +4 lines, -6 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.h View 1 chunk +16 lines, -10 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.cc View 5 chunks +18 lines, -23 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format_test.cc View 5 chunks +21 lines, -33 lines 0 comments Download
M net/spdy/spdy_framer.h View 2 chunks +5 lines, -6 lines 0 comments Download
M net/spdy/spdy_framer.cc View 3 chunks +6 lines, -16 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 4 chunks +33 lines, -25 lines 0 comments Download
M net/spdy/spdy_protocol.h View 2 chunks +16 lines, -15 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 6 months ago (2015-06-09 19:39:31 UTC) #2
Ryan Hamilton
lgtm
5 years, 6 months ago (2015-06-09 22:11:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171183002/1
5 years, 6 months ago (2015-06-10 11:19:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 11:22:54 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 11:23:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d172e66b4c118176070cabb53afc2f9bff637c1b
Cr-Commit-Position: refs/heads/master@{#333717}

Powered by Google App Engine
This is Rietveld 408576698