Right-size the toolbar

Right-size the toolbar

Tweaked the layout in Scaffold a little: the Scaffold
accounts for the (Android) notification bar's height,
instead of the ToolBar. I think it would be best if
moving the app below the notification area were handled
at a lower level. Doing it in Scaffold seemed OK for the
moment, since one could put a ToolBar component anywhere
in an app.

Closes #208

R=ianh@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/cb071d344ecb2b76a580628b347066b42efdd3b6

[hansmuller, 2015-06-10 16:25:11]

hansmuller@chromium.org changed reviewers:
+ ianh@google.com

[hansmuller, 2015-06-10 16:27:27]

hansmuller@chromium.org changed reviewers:
+ hansmuller@chromium.org

[hansmuller, 2015-06-10 16:27:27]

PTAL

[Hixie, 2015-06-10 16:50:02]

If the toolbar doesn't have responsibility for getting past the notification
area, then how does the toolbar colour get to bleed under the notification area?

I think the right way to do this is to have the toolbar at 0,0 and responsible
for going past the notification area, but if there's no toolbar, then you
implicitly increase bodyPosition by kNotificationAreaHeight.

[hansmuller, 2015-06-10 17:45:07]

The toolbar's contents are now bottom justified within a
kToolBarHeight child. Scaffold expands the toolbar to fill
the notification area.

PTAL

[abarth-chromium, 2015-06-10 17:50:40]

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
File sky/sdk/lib/framework/components2/tool_bar.dart (right):

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
sky/sdk/lib/framework/components2/tool_bar.dart:38: var bottomJustifiedChild =
new FlexContainer(
Can you add a TODO comment about this being a workaround for the lack of
align-items: flex-end?

[hansmuller, 2015-06-10 17:56:10]

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
File sky/sdk/lib/framework/components2/tool_bar.dart (right):

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
sky/sdk/lib/framework/components2/tool_bar.dart:38: var bottomJustifiedChild =
new FlexContainer(
On 2015/06/10 17:50:40, abarth wrote:
> Can you add a TODO comment about this being a workaround for the lack of
> align-items: flex-end?

Done.

[abarth-chromium, 2015-06-10 17:56:57]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-06-10 17:56:58]

lgtm

[Hixie, 2015-06-10 17:57:12]

ianh@google.com changed reviewers:
- abarth@chromium.org

[Hixie, 2015-06-10 17:57:13]

lgtm

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
File sky/sdk/lib/framework/components2/scaffold.dart (right):

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
sky/sdk/lib/framework/components2/scaffold.dart:90: var toolbarHeight =
kToolBarHeight + kNotificationAreaHeight;
double, not var.

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
sky/sdk/lib/framework/components2/scaffold.dart:93: toolbar.parentData.position
= new Point(0.0, bodyPosition);
Go back to Point.origin, unless there's reason to believe bodyPosition will not
be zero here.

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
File sky/sdk/lib/framework/components2/tool_bar.dart (right):

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
sky/sdk/lib/framework/components2/tool_bar.dart:38: var bottomJustifiedChild =
new FlexContainer(
UINode, not var.

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
sky/sdk/lib/framework/components2/tool_bar.dart:47: padding: new EdgeDims(0.0,
8.0, 0.0, 8.0),
Use the EdgeDims constructor for symmetric sides.

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/t...
File sky/sdk/lib/framework/theme2/view_configuration.dart (right):

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/t...
sky/sdk/lib/framework/theme2/view_configuration.dart:9: const double
kStatusBarHeight = 50.0;
Add // TODO(ianh): Figure out actual specced height for status bar
...to the kStatusBarHeight line please. Thanks.

[hansmuller, 2015-06-10 18:06:24]

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
File sky/sdk/lib/framework/components2/scaffold.dart (right):

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
sky/sdk/lib/framework/components2/scaffold.dart:90: var toolbarHeight =
kToolBarHeight + kNotificationAreaHeight;
On 2015/06/10 17:57:13, Hixie wrote:
> double, not var.

Done.

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
sky/sdk/lib/framework/components2/scaffold.dart:93: toolbar.parentData.position
= new Point(0.0, bodyPosition);
On 2015/06/10 17:57:13, Hixie wrote:
> Go back to Point.origin, unless there's reason to believe bodyPosition will
not
> be zero here.

Done.

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
File sky/sdk/lib/framework/components2/tool_bar.dart (right):

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/c...
sky/sdk/lib/framework/components2/tool_bar.dart:47: padding: new EdgeDims(0.0,
8.0, 0.0, 8.0),
On 2015/06/10 17:57:13, Hixie wrote:
> Use the EdgeDims constructor for symmetric sides.

Done. That's much clearer.

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/t...
File sky/sdk/lib/framework/theme2/view_configuration.dart (right):

https://codereview.chromium.org/1171173003/diff/20001/sky/sdk/lib/framework/t...
sky/sdk/lib/framework/theme2/view_configuration.dart:9: const double
kStatusBarHeight = 50.0;
On 2015/06/10 17:57:13, Hixie wrote:
> Add // TODO(ianh): Figure out actual specced height for status bar
> ...to the kStatusBarHeight line please. Thanks.

Done.

[hansmuller1, 2015-06-10 18:06:59]

Committed patchset #4 (id:60001) manually as
cb071d344ecb2b76a580628b347066b42efdd3b6 (presubmit successful).