Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 1171173002: [Background Sync] Use Mojo IPC to fire background sync events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move ServiceWorkerMojoEventDispatcher to ServiceWorkerDispatcherHost Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index 0c3fedb14f76a46b659781a10ad2892beeeda60b..951cec0109ca111a84c3c43510ceca3b8fed5a40 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -23,6 +23,7 @@
#include "content/browser/service_worker/service_worker_context_core.h"
#include "content/browser/service_worker/service_worker_context_wrapper.h"
#include "content/browser/service_worker/service_worker_metrics.h"
+#include "content/browser/service_worker/service_worker_mojo_event_dispatcher.h"
#include "content/browser/service_worker/service_worker_registration.h"
#include "content/browser/service_worker/service_worker_utils.h"
#include "content/browser/service_worker/stashed_port_manager.h"
@@ -39,6 +40,7 @@
#include "content/public/common/content_client.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/result_codes.h"
+#include "content/public/common/service_registry.h"
#include "net/http/http_response_headers.h"
#include "net/http/http_response_info.h"
@@ -761,12 +763,13 @@ void ServiceWorkerVersion::DispatchSyncEvent(const StatusCallback& callback) {
}
int request_id = AddRequest(callback, &sync_callbacks_, REQUEST_SYNC);
- ServiceWorkerStatusCode status = embedded_worker_->SendMessage(
- ServiceWorkerMsg_SyncEvent(request_id));
- if (status != SERVICE_WORKER_OK) {
- sync_callbacks_.Remove(request_id);
- RunSoon(base::Bind(callback, status));
- }
+ ServiceWorkerMojoEventDispatcher* mojo_event_dispatcher =
+ context_->GetMojoEventDispatcher(embedded_worker_->process_id());
+ DCHECK(mojo_event_dispatcher);
+ mojo_event_dispatcher->DispatchSyncEvent(
+ embedded_worker_->thread_id(),
+ base::Bind(&self::OnSyncEventFinished, weak_factory_.GetWeakPtr(),
+ request_id));
}
void ServiceWorkerVersion::DispatchNotificationClickEvent(
@@ -1181,8 +1184,6 @@ bool ServiceWorkerVersion::OnMessageReceived(const IPC::Message& message) {
OnInstallEventFinished)
IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_FetchEventFinished,
OnFetchEventFinished)
- IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_SyncEventFinished,
- OnSyncEventFinished)
IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_NotificationClickEventFinished,
OnNotificationClickEventFinished)
IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_PushEventFinished,
@@ -1354,9 +1355,8 @@ void ServiceWorkerVersion::OnFetchEventFinished(
RemoveCallbackAndStopIfRedundant(&fetch_callbacks_, request_id);
}
-void ServiceWorkerVersion::OnSyncEventFinished(
- int request_id,
- blink::WebServiceWorkerEventResult result) {
+void ServiceWorkerVersion::OnSyncEventFinished(int request_id,
+ ServiceWorkerStatusCode status) {
TRACE_EVENT1("ServiceWorker",
"ServiceWorkerVersion::OnSyncEventFinished",
"Request id", request_id);
@@ -1366,14 +1366,11 @@ void ServiceWorkerVersion::OnSyncEventFinished(
return;
}
- ServiceWorkerStatusCode status = SERVICE_WORKER_OK;
if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableServiceWorkerSync)) {
// Avoid potential race condition where flag is disabled after a sync event
// was dispatched
status = SERVICE_WORKER_ERROR_ABORT;
- } else if (result == blink::WebServiceWorkerEventResultRejected) {
- status = SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED;
}
scoped_refptr<ServiceWorkerVersion> protect(this);

Powered by Google App Engine
This is Rietveld 408576698