content/common/background_sync_service.mojom - Issue 1171173002: [Background Sync] Use Mojo IPC to fire background sync events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/background_sync_service.mojom

Issue 1171173002: [Background Sync] Use Mojo IPC to fire background sync events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing style nits Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.h ('K') | « content/browser/service_worker/service_worker_version.cc ('k') | content/common/service_worker/service_worker_messages.h » ('j') | content/renderer/background_sync/background_sync_client_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/background_sync_service.mojom

diff --git a/content/common/background_sync_service.mojom b/content/common/background_sync_service.mojom

index 8321ae9dc7dccaa479d14e538c63500ddedc939d..c95afba5f3ae8441a9db090a2f6caf13aff12a68 100644

--- a/content/common/background_sync_service.mojom

+++ b/content/common/background_sync_service.mojom

@@ -6,6 +6,7 @@ module content;

import "content/public/common/background_sync.mojom";

import "content/public/common/permission_status.mojom";

+import "content/public/common/service_worker_event_status.mojom";

enum BackgroundSyncError {

NONE,

@@ -31,7 +32,8 @@ interface BackgroundSyncService {

=> (BackgroundSyncError err, PermissionStatus status);

};

-interface BackgoundSyncServiceClient {

- Sync(SyncRegistration event);

+interface BackgroundSyncServiceClient {

+ Sync(SyncRegistration event, int32 thread_id)

jkarlin 2015/06/18 18:13:56 perhaps rename event to registration? Event isn't

iclelland 2015/06/19 13:44:32 Yes -- I thought I'd fixed all of those; apparentl

+ => (ServiceWorkerEventStatus status);

};