[Background Sync] Use Mojo IPC to fire background sync events

content/browser/service_worker/service_worker_mojo_event_dispatcher.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_MOJO_EVENT_DISPATCHER_H_
+#define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_MOJO_EVENT_DISPATCHER_H_
+
+#include "base/memory/ref_counted.h"
+#include "content/browser/service_worker/service_worker_version.h"
+#include "content/common/background_sync_service.mojom.h"
+#include "content/common/service_worker/service_worker_status_code.h"
+#include "content/public/browser/browser_thread.h"
+
+namespace content {
+
+// This class is used by ServiceWorkerVersion to fire events in the service
+// worker using mojo IPC. It owns an InterfacePtr to each service, which it will
+// construct as necessary.
+//
+// All public methods must be called on IO thread, and callbacks will be
+// executed on that thread. Can be constructed, owned and destructed on a
+// separate thread.

[jkarlin, 2015/06/16 19:00:00]

The above paragraph is out of date. Just mention that this class should be
called on the IO thread.

[iclelland, 2015/06/17 12:39:26]

Done.

+class ServiceWorkerMojoEventDispatcher
+    : public base::RefCountedThreadSafe<ServiceWorkerMojoEventDispatcher,

[jkarlin, 2015/06/16 19:00:00]

This doesn't need to be RefCounted any longer. Instead, add a WeakPtrFactory
member and use the weak ptr for your posts. 

[iclelland, 2015/06/17 12:39:24]

Done.

+                                        BrowserThread::DeleteOnIOThread> {
+ public:
+  ServiceWorkerMojoEventDispatcher();
+
+  // Dispatches the event, establishing a connection to the mojo service if
+  // necessary, and then runs |callback| with the result.
+  void DispatchSyncEvent(int render_process_id,
+                         int thread_id,
+                         const ServiceWorkerVersion::StatusCallback& callback);
+
+ private:
+  template <typename MojoServicePtrType>

[jkarlin, 2015/06/16 19:00:00]

The typename differs between here and source file. Is it MojoServicePtrType or
MojoServiceType?

[iclelland, 2015/06/17 12:39:27]

Thanks -- I didn't catch that. Should be MojoServiceType (I call out
InterfacePtr<MojoServiceType> when necessary)

+  void Connect(int render_process_id,
+               const base::Callback<
+                   void(mojo::InterfacePtrInfo<MojoServicePtrType>)>& callback);
+  void BindChannelAndDispatchSyncEvent(
+      int thread_id,
+      const ServiceWorkerVersion::StatusCallback& callback,
+      mojo::InterfacePtrInfo<BackgroundSyncServiceClient> ptri);
+  void DispatchSyncEventInternal(
+      int thread_id,
+      const ServiceWorkerVersion::StatusCallback& callback);
+
+  friend class base::RefCountedThreadSafe<ServiceWorkerMojoEventDispatcher,
+                                          BrowserThread::DeleteOnIOThread>;
+  friend struct BrowserThread::DeleteOnThread<BrowserThread::IO>;
+  friend class base::DeleteHelper<ServiceWorkerMojoEventDispatcher>;

[jkarlin, 2015/06/16 19:00:00]

delete the above friends

[iclelland, 2015/06/17 12:39:27]

Done.

+
+  ~ServiceWorkerMojoEventDispatcher();
+
+  void OnEventFinished(const ServiceWorkerVersion::StatusCallback& callback,
+                       ServiceWorkerEventStatus result);
+
+  BackgroundSyncServiceClientPtr background_sync_client_;

[jkarlin, 2015/06/16 19:00:00]

DISALLOW_COPY_AND_ASSIGN(ServiceWorkerMojoEventDispatcher);

[iclelland, 2015/06/17 12:39:26]

Done.

+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_MOJO_EVENT_DISPATCHER_H_