Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1171163003: Relanding "Added UMA statistics for changing the active window via click or touch events." (Closed)

Created:
5 years, 6 months ago by bruthig
Modified:
5 years, 6 months ago
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relanding "Added UMA statistics for changing the active window via click or touch events." Previously reverted by r333185. TEST=TaskSwitchMetricsRecorderTest.VerifyTaskSwitchesForDesktopAreRecorded TEST=DesktopTaskSwitchMetricRecorderTest.ActivatePositionableWindowWhenNullWindowWasActivatedLast TEST=DesktopTaskSwitchMetricRecorderTest.ActivatePositionableWindowWhenADifferentPositionableWindowWasActivatedLast TEST=DesktopTaskSwitchMetricRecorderTest.ActivatePositionableWindowWhenTheSamePositionableWindowWasActivatedLast TEST=DesktopTaskSwitchMetricRecorderTest.ActivatePositionableWindowWhenANonPositionableWindowWasActivatedLast TEST=DesktopTaskSwitchMetricRecorderTest.ActivateNonPositionableWindowBetweenTwoPositionableWindowActivations TEST=DesktopTaskSwitchMetricRecorderTest.ActivateNullWindow TEST=DesktopTaskSwitchMetricRecorderTest.ActivateNonPositionableWindow TEST=DesktopTaskSwitchMetricRecorderTest.ActivatePositionableWindowWithNonInputEventReason TEST=DesktopTaskSwitchMetricRecorderWithShellIntegrationTest.ActivatePositionableWindowWithInputEvent TEST=DesktopTaskSwitchMetricRecorderWithShellIntegrationTest.ActivatePositionableWindowWithNonInputEvent BUG=489813, 489814 Committed: https://crrev.com/c24d11ffac5289bf8a2cd6d405cec0ed5fdde06c Cr-Commit-Position: refs/heads/master@{#333577}

Patch Set 1 #

Patch Set 2 : Fixed memory leak. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+506 lines, -0 lines) Patch
M ash/ash.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
A ash/metrics/desktop_task_switch_metric_recorder.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ash/metrics/desktop_task_switch_metric_recorder.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A ash/metrics/desktop_task_switch_metric_recorder_unittest.cc View 1 1 chunk +338 lines, -0 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder.h View 2 chunks +8 lines, -0 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M ash/metrics/user_metrics_recorder.h View 4 chunks +15 lines, -0 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M ash/shell.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bruthig
This is a re-landing of https://codereview.chromium.org/1153633006/ with a very small difference in ash/metrics/desktop_task_switch_metric_recorder_unittest.cc which is ...
5 years, 6 months ago (2015-06-09 19:05:26 UTC) #2
sky
LGTM
5 years, 6 months ago (2015-06-09 19:30:18 UTC) #3
Alexei Svitkine (slow)
lgtm
5 years, 6 months ago (2015-06-09 20:03:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171163003/20001
5 years, 6 months ago (2015-06-09 20:05:23 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 21:30:14 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 21:31:03 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c24d11ffac5289bf8a2cd6d405cec0ed5fdde06c
Cr-Commit-Position: refs/heads/master@{#333577}

Powered by Google App Engine
This is Rietveld 408576698