Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1171113002: [Telemetry] Add Deprecated decorators and apply it for page_set (Closed)

Created:
5 years, 6 months ago by nednguyen
Modified:
5 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add Deprecated decorators and apply it for page_set BUG=439512, 472215 TEST=./tools/perf/run_benchmark --browser=system smoothness.maps Committed: https://crrev.com/e42f0a75cfcca53367974a500cb8b5b66f75a3a5 Cr-Commit-Position: refs/heads/master@{#333647}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add unittest. Address Kari's comment #

Patch Set 3 : Address Dave's grammar nits #

Patch Set 4 : Fix unittest after grammar fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -1 line) Patch
M tools/telemetry/telemetry/decorators.py View 1 2 2 chunks +64 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/decorators_unittest.py View 1 2 3 2 chunks +79 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
nednguyen
5 years, 6 months ago (2015-06-09 17:29:24 UTC) #2
aiolos (Not reviewing)
https://codereview.chromium.org/1171113002/diff/1/tools/telemetry/telemetry/page/page_set.py File tools/telemetry/telemetry/page/page_set.py (right): https://codereview.chromium.org/1171113002/diff/1/tools/telemetry/telemetry/page/page_set.py#newcode16 tools/telemetry/telemetry/page/page_set.py:16: 2015, 6, 25, 'Please switch to use UserStory class ...
5 years, 6 months ago (2015-06-09 17:45:01 UTC) #3
sullivan
lgtm
5 years, 6 months ago (2015-06-09 18:50:54 UTC) #4
eakuefner
lgtm % unittests plox
5 years, 6 months ago (2015-06-09 20:04:52 UTC) #5
nednguyen
https://codereview.chromium.org/1171113002/diff/1/tools/telemetry/telemetry/page/page_set.py File tools/telemetry/telemetry/page/page_set.py (right): https://codereview.chromium.org/1171113002/diff/1/tools/telemetry/telemetry/page/page_set.py#newcode16 tools/telemetry/telemetry/page/page_set.py:16: 2015, 6, 25, 'Please switch to use UserStory class ...
5 years, 6 months ago (2015-06-09 21:43:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171113002/20001
5 years, 6 months ago (2015-06-09 21:45:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171113002/40001
5 years, 6 months ago (2015-06-09 21:51:24 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/73583)
5 years, 6 months ago (2015-06-09 23:40:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171113002/60001
5 years, 6 months ago (2015-06-09 23:44:23 UTC) #18
aiolos (Not reviewing)
lgtm
5 years, 6 months ago (2015-06-10 00:36:19 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-10 02:01:43 UTC) #20
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 02:03:36 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e42f0a75cfcca53367974a500cb8b5b66f75a3a5
Cr-Commit-Position: refs/heads/master@{#333647}

Powered by Google App Engine
This is Rietveld 408576698