Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: sky/engine/core/painting/PaintingStyle.h

Issue 1170963003: Sky: Add a DartConverterEnum and use that for all our enum needs. (Closed) Base URL: git@github.com:/domokit/mojo.git@master
Patch Set: 360 no scope Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/painting/Gradient.idl ('k') | sky/engine/core/painting/PaintingStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/painting/PaintingStyle.h
diff --git a/sky/engine/core/painting/PaintingStyle.h b/sky/engine/core/painting/PaintingStyle.h
index c08378563317c35cf76ab6b70ffc402dfbf86acd..797b82d81d7f60c591814cd95dde60f8e7ca0046 100644
--- a/sky/engine/core/painting/PaintingStyle.h
+++ b/sky/engine/core/painting/PaintingStyle.h
@@ -5,10 +5,7 @@
#ifndef SKY_ENGINE_CORE_PAINTING_PAINTINGSTYLE_H_
#define SKY_ENGINE_CORE_PAINTING_PAINTINGSTYLE_H_
-#include "sky/engine/core/painting/Rect.h"
-#include "sky/engine/tonic/dart_wrappable.h"
-#include "sky/engine/wtf/PassRefPtr.h"
-#include "sky/engine/wtf/RefCounted.h"
+#include "sky/engine/tonic/dart_converter.h"
#include "third_party/skia/include/core/SkPaint.h"
namespace blink {
@@ -16,12 +13,14 @@ namespace blink {
class PaintingStyle {};
template <>
-struct DartConverter<PaintingStyle> {
- static SkPaint::Style FromArgumentsWithNullCheck(Dart_NativeArguments args,
- int index,
- Dart_Handle& exception);
+struct DartConverter<PaintingStyle> : public DartConverterEnum<SkPaint::Style> {
};
+// If this fails, it's because SkPaint::Style has changed. We need to change
+// PaintingStyle.dart to ensure the PaintingStyle enum is in sync with the C++
+// values.
+COMPILE_ASSERT(SkPaint::kStyleCount == 3, Need_to_update_PaintingStyle_dart);
+
} // namespace blink
#endif // SKY_ENGINE_CORE_PAINTING_PAINTINGSTYLE_H_
« no previous file with comments | « sky/engine/core/painting/Gradient.idl ('k') | sky/engine/core/painting/PaintingStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698