Sky: Add a DartConverterEnum and use that for all our enum needs.

sky/engine/tonic/dart_state.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sky/engine/config.h"
 #include "sky/engine/tonic/dart_state.h"
 
 #include "sky/engine/tonic/dart_class_library.h"
+#include "sky/engine/tonic/dart_converter.h"
 #include "sky/engine/tonic/dart_exception_factory.h"
 #include "sky/engine/tonic/dart_string_cache.h"
 #include "sky/engine/tonic/dart_timer_heap.h"
 #include "sky/engine/wtf/PassOwnPtr.h"
 
 namespace blink {
 
 DartState::Scope::Scope(DartState* dart_state) : scope_(dart_state->isolate()) {
 }
 
 DartState::Scope::~Scope() {
 }
 
 DartState::DartState()
     : isolate_(NULL),
       class_library_(adoptPtr(new DartClassLibrary)),
       string_cache_(adoptPtr(new DartStringCache)),
       exception_factory_(adoptPtr(new DartExceptionFactory(this))),
       timer_heap_(adoptPtr(new DartTimerHeap())),
       weak_factory_(this) {
 }
 
 DartState::~DartState() {
 }
 
+void DartState::DidSetIsolateInternal() {
+  Scope dart_scope(this);
+  index_handle_.Set(this, ToDart("index"));
+
+  DidSetIsolate();

[abarth-chromium, 2015/06/09 19:51:37]

Do we want dart_scope to be on the stack while we're calling DidSetIsolate? 
Just asking.  I'm not sure one way or another.  It just seems like a change from
what we had previously.

[Matt Perry, 2015/06/09 19:52:47]

Yeah I could go either way.

[Matt Perry, 2015/06/09 19:55:39]

Went back to the old way since it's less mysterious.

+}
+
 DartState* DartState::From(Dart_Isolate isolate) {
   return static_cast<DartState*>(Dart_IsolateData(isolate));
 }
 
 DartState* DartState::Current() {
   return static_cast<DartState*>(Dart_CurrentIsolateData());
 }
 
 base::WeakPtr<DartState> DartState::GetWeakPtr() {
   return weak_factory_.GetWeakPtr();
 }
 
 }  // namespace blink