Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(64)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1170963002: Componentization: make core classes visible for blink_tests and blink_web. (Closed)

Created:
4 years, 10 months ago by tasak
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, dshwang, sof, eae+blinkwatch, slimming-paint-reviews_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-paint_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Componentization: make visible for blink_tests and blink_web. - Source/web/WebLocalFrameImpl.cpp uses 'blink::ScopeRecorder'. - Source/web/WebViewImpl.cpp uses 'blink::PageScaleConstraintsSet'. - Source/core/dom/AttrTest.cpp uses 'blink::Attr'. - Source/core/events/EventPathTest.cpp uses ''blink::PseudoElement', 'blink::EventPath', 'blink::TreeScopeEventContext', and 'blink::NodeEventContext'. - Source/core/frame/OriginsUsingFeaturesTest.cpp uses 'blink::OriginsUsingFeatures'. BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M Source/core/dom/Attr.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/PseudoElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/events/EventPath.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/events/NodeEventContext.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/events/TreeScopeEventContext.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/frame/OriginsUsingFeatures.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/frame/PageScaleConstraintsSet.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayerStackingNode.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/ScopeRecorder.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tasak
PTAL?
4 years, 10 months ago (2015-06-09 06:24:12 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-09 06:39:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170963002/1
4 years, 10 months ago (2015-06-09 12:14:08 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 12:18:10 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196759

Powered by Google App Engine
This is Rietveld 408576698