Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1170923005: Revert of Combine 'pssh' parsing routines. (Closed)

Created:
5 years, 6 months ago by Rune Fevang
Modified:
5 years, 6 months ago
CC:
chromium-reviews, eme-reviews_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Combine 'pssh' parsing routines. (patchset #7 id:120001 of https://codereview.chromium.org/1149023002/) Reason for revert: Broke Google Chrome Mac build: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/1748/steps/compile/logs/stdio Original issue's description: > Combine CENC 'pssh' box parsing routines. > > Also update the routines to ignore 'pssh' boxes with version 2 or > later. > > BUG=460359, 460360 > TEST=new unittests pass > > Committed: https://crrev.com/b666d7874efac44b359a95329f0cb890e97671df > Cr-Commit-Position: refs/heads/master@{#333556} TBR=sandersd@chromium.org,ddorwin@chromium.org,xhwang@chromium.org,jrummell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460359, 460360 Committed: https://crrev.com/aaa96a77ea169e968e73a7d613deae52bfa369c5 Cr-Commit-Position: refs/heads/master@{#333568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -388 lines) Patch
M components/cdm/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/cdm/browser/widevine_drm_delegate_android.cc View 2 chunks +137 lines, -3 lines 0 comments Download
M media/cdm/cenc_utils.h View 1 chunk +0 lines, -11 lines 0 comments Download
M media/cdm/cenc_utils.cc View 3 chunks +134 lines, -77 lines 0 comments Download
M media/cdm/cenc_utils_unittest.cc View 12 chunks +38 lines, -171 lines 0 comments Download
M media/formats/mp4/box_definitions.h View 1 chunk +1 line, -11 lines 0 comments Download
M media/formats/mp4/box_definitions.cc View 1 chunk +4 lines, -53 lines 0 comments Download
M media/formats/mp4/box_reader.h View 4 chunks +3 lines, -16 lines 0 comments Download
M media/formats/mp4/box_reader.cc View 7 chunks +15 lines, -45 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Rune Fevang
Created Revert of Combine 'pssh' parsing routines.
5 years, 6 months ago (2015-06-09 20:43:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170923005/1
5 years, 6 months ago (2015-06-09 20:44:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 20:46:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aaa96a77ea169e968e73a7d613deae52bfa369c5 Cr-Commit-Position: refs/heads/master@{#333568}
5 years, 6 months ago (2015-06-09 20:47:40 UTC) #4
Nico
5 years, 6 months ago (2015-06-09 21:15:08 UTC) #6
Message was sent while issue was closed.
broke official windows builds too:
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/1301/step...

Powered by Google App Engine
This is Rietveld 408576698