Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 1170923004: Reland "MIPS64: Fix lithium arithmetic operations for integers to sign-extend result." (Closed)

Created:
5 years, 6 months ago by dusmil.imgtec
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "MIPS64: Fix lithium arithmetic operations for integers to sign-extend result." TEST==mjsunit/asm/double-lo BUG= Committed: https://crrev.com/14151c81a26502fb50ba096fb7cdac9c0d7a201b Cr-Commit-Position: refs/heads/master@{#29078}

Patch Set 1 #

Patch Set 2 : Separate Int and Smi arithemtic lithium operations, fix add/sub overflow checks. #

Patch Set 3 : Remove DeoptimizeIf workaround. #

Patch Set 4 : Remove DeoptimizeIf workaround 2. #

Patch Set 5 : Rebase and remove at as default scratch reg in Operand versions of overflow operations. #

Patch Set 6 : Include fix of removed EmitLoadRegister unsafe usage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -106 lines) Patch
M src/mips64/full-codegen-mips64.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 2 3 4 5 8 chunks +162 lines, -71 lines 0 comments Download
M src/mips64/lithium-mips64.h View 1 6 chunks +49 lines, -1 line 0 comments Download
M src/mips64/lithium-mips64.cc View 1 3 chunks +15 lines, -8 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 3 4 2 chunks +16 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 3 4 5 8 chunks +142 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dusmil.imgtec
PTAL.
5 years, 6 months ago (2015-06-12 14:11:53 UTC) #2
paul.l...
LGTM. You need to rebase after 9af578a7 (macro-assembler-mips64 changes).
5 years, 6 months ago (2015-06-15 16:45:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170923004/90007
5 years, 6 months ago (2015-06-17 10:35:57 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:90007)
5 years, 6 months ago (2015-06-17 10:58:52 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 10:59:02 UTC) #8
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/14151c81a26502fb50ba096fb7cdac9c0d7a201b
Cr-Commit-Position: refs/heads/master@{#29078}

Powered by Google App Engine
This is Rietveld 408576698