Issue 1170913002: Clamp animated lengths to CSS length range to match CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1170913002: Clamp animated lengths to CSS length range to match CSSPrimitiveValue (Closed)

Created:
4 years, 10 months ago by alancutter (OOO until 2018)

Modified:
4 years, 10 months ago

Reviewers:
sashab

CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, Eric Willigers, rjwright, shans

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Clamp animated lengths to CSS length range to match CSSPrimitiveValue This patch fixes an inconsistency between the LengthStyleInterpolation fast path and CSSPrimitiveValue's computeLength() by clamping the interpolated Length values to the appropriate CSS length range. BUG=494927 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196733

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	A	LayoutTests/animations/css-length-range-crash.html	View		1 chunk	+18 lines, -0 lines	0 comments	Download
	M	Source/core/animation/LengthStyleInterpolation.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170913002/1

4 years, 10 months ago (2015-06-09 03:26:45 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-09 04:41:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196733

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages